This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxl: Lists qdisk device in libxl_device_disk_l

anthony.perard@xxxxxxxxxx writes ("[Xen-devel] [PATCH] libxl: Lists qdisk 
device in libxl_device_disk_list"):
> As libxl switch to qdisk when blktap isn't available, this patch makes
> libxl_device_disk_list also list qdisk device. So
> libxl_build_device_model_args_new will be able to add qdisk device to
> the command line options of Qemu.

Thanks for this contribution.  But what you have done is introduced
yet a third copy of a section of code which has been cloned-and-hacked
one already.

Can you please make a patch which breaks the common code out into a
separate function, or macro, or uses a loop, or something ?  I don't
much mind how it's done but to my mind a function is probably going to
be easiest.


Xen-devel mailing list