WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix build error in libxl

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix build error in libxl
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Mon, 3 Jan 2011 14:40:08 +0100
Cc: "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
Delivery-date: Mon, 03 Jan 2011 05:41:11 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <749B9D3DBF0F054390025D9EAFF47F223195EEB1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <749B9D3DBF0F054390025D9EAFF47F223195EEB1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.10
On Thursday 23 December 2010 03:08:38 Zhang, Yang Z wrote:
> Move free(disks) into the bracket, or it will show error 'disks' used
> uninitialized when build libxl.

I have the same build problem. My patch is very similar:
http://lists.xensource.com/archives/html/xen-devel/2010-12/msg01011.html

Christoph


>
> best regards
> yang
>
> diff -r f69037cc4674 tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c       Wed Dec 22 17:48:31 2010 +0000
> +++ b/tools/libxl/libxl.c       Thu Dec 23 10:03:35 2010 +0800
> @@ -1402,8 +1402,8 @@
>              }
>              libxl_device_disk_destroy(&disks[i]);
>          }
> +        free(disks);
>      }
> -    free(disks);
>      flexarray_set(dm_args, num++, NULL);
>      return (char **) flexarray_contents(dm_args);
>  }
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>