diff -r 89116f28083f tools/xenstore/xs.c --- a/tools/xenstore/xs.c Wed Dec 08 10:46:31 2010 +0000 +++ b/tools/xenstore/xs.c Fri Dec 10 03:39:56 2010 -0800 @@ -182,12 +182,15 @@ return -1; } -static int get_dev(const char *connect_to) +static int get_dev(const char *connect_to, int mode) { - return open(connect_to, O_RDWR); + if (mode & XS_OPEN_READONLY) + return open(connect_to, O_RDONLY); + else + return open(connect_to, O_RDWR); } -static struct xs_handle *get_handle(const char *connect_to) +static struct xs_handle *get_handle(const char *connect_to, int mode) { struct stat buf; struct xs_handle *h = NULL; @@ -199,7 +202,7 @@ if (S_ISSOCK(buf.st_mode)) fd = get_socket(connect_to); else - fd = get_dev(connect_to); + fd = get_dev(connect_to, mode); if (fd == -1) return NULL; @@ -237,17 +240,32 @@ struct xs_handle *xs_daemon_open(void) { - return get_handle(xs_daemon_socket()); + return xs_open(0); } struct xs_handle *xs_daemon_open_readonly(void) { - return get_handle(xs_daemon_socket_ro()); + return xs_open(XS_OPEN_READONLY); } struct xs_handle *xs_domain_open(void) { - return get_handle(xs_domain_dev()); + return xs_open(0); +} + +struct xs_handle *xs_open(int mode) +{ + struct xs_handle *xsh = NULL; + + if (mode & XS_OPEN_READONLY) + xsh = get_handle(xs_daemon_socket_ro(), mode); + else + xsh = get_handle(xs_daemon_socket(), mode); + + if (!xsh) + xsh = get_handle(xs_domain_dev(), mode); + + return xsh; } static void close_free_msgs(struct xs_handle *h) { @@ -303,6 +321,12 @@ close_fds_free(h); } +void xs_close(struct xs_handle* xsh) +{ + if (xsh) + xs_daemon_close(xsh); +} + static bool read_all(int fd, void *data, unsigned int len) { while (len) { diff -r 89116f28083f tools/xenstore/xs.h --- a/tools/xenstore/xs.h Wed Dec 08 10:46:31 2010 +0000 +++ b/tools/xenstore/xs.h Fri Dec 10 03:39:56 2010 -0800 @@ -24,6 +24,8 @@ #define XBT_NULL 0 +#define XS_OPEN_READONLY 1<<0 + struct xs_handle; typedef uint32_t xs_transaction_t; @@ -34,18 +36,34 @@ /* On failure, these routines set errno. */ +/* Open a connection to the xs daemon. + * Attempts to make a connection over the socket interface, + * and if it fails, then over the xenbus interface. + * Mode 0 specifies read-write access, XS_OPEN_READONLY for + * read-only access. + * Returns a handle or NULL. + */ +struct xs_handle *xs_open(int mode); + +/* Close the connection to the xs daemon. */ +void xs_close(struct xs_handle *xsh); + /* Connect to the xs daemon. * Returns a handle or NULL. + * Deprecated, please use xs_open(0) instead */ struct xs_handle *xs_daemon_open(void); struct xs_handle *xs_domain_open(void); /* Connect to the xs daemon (readonly for non-root clients). * Returns a handle or NULL. + * Deprecated, please use xs_open(XS_OPEN_READONLY) instead */ struct xs_handle *xs_daemon_open_readonly(void); -/* Close the connection to the xs daemon. */ +/* Close the connection to the xs daemon. + * Deprecated, please use xs_close() instead + */ void xs_daemon_close(struct xs_handle *); /* Throw away the connection to the xs daemon, for use after fork(). */