WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] svm: support VMCB cleanbits

To: Keir Fraser <keir@xxxxxxx>, "Egger, Christoph" <Christoph.Egger@xxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] svm: support VMCB cleanbits
From: "Huang2, Wei" <Wei.Huang2@xxxxxxx>
Date: Wed, 15 Dec 2010 17:04:29 -0600
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 15 Dec 2010 15:06:56 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C92EA3AE.294F8%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201012151336.59224.Christoph.Egger@xxxxxxx> <C92EA3AE.294F8%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcucePuFY4rqS1zwQ065oCfupDHb6wAMlgbA
Thread-topic: [Xen-devel] [PATCH] svm: support VMCB cleanbits
Hi Keir,

Thanks for putting up this patch. I think the comments you made are correct 
after reading the spec again. Christoph and I misread some APM content. :-(

Thanks again,
-Wei

-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Keir Fraser
Sent: Wednesday, December 15, 2010 10:56 AM
To: Egger, Christoph; Tim Deegan
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] svm: support VMCB cleanbits

On 15/12/2010 12:36, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> On Wednesday 15 December 2010 12:27:51 Tim Deegan wrote:
>> This seems to change the logic so it doesn't clear the intercepts if
>> debug_state == 0.  Is that OK?
> 
> No, that's not ok. I fixed that in the new patch.
> 
>> More generally, I'm not sure I like having all the VMCB accessor
>> functions in files called "cleanbits" -- wouldn't it make sense to have
>> all that in the vmcb files so people will see them and know to use them?
>> You could rename the actual vmcb fields as well to catch anyone writing
>> them directly, e.g. in forward-ported patches.
> 
> I renamed the 'svmcleanbits.[ch]' files to 'vmc_funcs.[ch]'
> 
> Thanks for your review.

I went through this patch quite brutally when I applied it (c/s 22546). In
particular I made the VMCB field accessor functions more consistent in name
and semantics, and pulled out their implementations into a common macro to
make the code clearer.

There should be no significant changes compared with your patch *EXCEPT*:
 1. Updates to the MSR and I/O bitmaps do not affect clear bits
 2. Updates to lbr_control.enable do not affect clear bits
 3. Updates to debugctlmsr *do* affect clear bits

In the above I am following what is described in AMD Volume 2 Section
15.15.3 "VMCB Clean Field".

I note that the MSRPM_BASE and IOPM_BASE fields are listed as cacheable, but
*no* mention is made of caching the bitmap contents.

Also, bit 10 (LBR) has debugctlmsr listed as cacheable, but again *no*
mention is made of the lbr_control.enable bit flag.

If any of the above is wrong, then: (a) the reference manual should be
fixed; (b) I would accept a fixup patch, with a patch description
explaininbg why behaviour is deviating from cleanbits behaviour describved
in the latest version of the AMD reference manuals.

 -- Keir

> Signed-off-by: Wei Huang <Wei.Huang2@xxxxxxx>
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> 
> Christoph
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel