 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][TOOLS] libxl: open code basename()
| To: | Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][TOOLS] libxl: open code basename() |
| From: | Juergen Gross <juergen.gross@xxxxxxxxxxxxxx> |
| Date: | Wed, 15 Dec 2010 13:23:54 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Wed, 15 Dec 2010 04:24:37 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1292415837; x=1323951837; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4D08B35A.7060200@xxxxxxxxxxxxxx>|Date:=20 Wed,=2015=20Dec=202010=2013:23:54=20+0100|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>|MIME-Version: =201.0|To:=20Christoph=20Egger=20<Christoph.Egger@xxxxxxx >|CC:=20xen-devel@xxxxxxxxxxxxxxxxxxx|Subject:=20Re:=20[X en-devel]=20[PATCH][TOOLS]=20libxl:=20open=20code=20basen ame()|References:=20<201012151312.59779.Christoph.Egger@a md.com>|In-Reply-To:=20<201012151312.59779.Christoph.Egge r@xxxxxxx>|Content-Transfer-Encoding:=207bit; bh=K+HzY8Cg4PNfwiovq2ZmmBSutLdfr98a5sRE1aHjdHE=; b=V1rkszIHChfXa3716zZBPV1oM5WxD5WCq0Lv0r8DGhY9VcwR8jnSmfDJ jxW0JlmAAviil2VnIfPibz5/rVpaTzOheWn9Kwl/6g05fvhtLtPNmWAu8 cd7ixDyi3bX5chozOWHEsUM8cjir+ykdrdfOLUD78lzd0zDBdKh730vHx mpJ7NLsbKZLl1l4mC7dz3PKGebxDJQT+JwN+lGGmiaOOg5H1yofxyr6Rc RGfOw9YdBRj955dkAffmWzmtsvIBU; |
| Domainkey-signature: | s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=EXLWM5HP74ip+h157NUEnLvmn3sCPPqUK5JL8gA30lDiRQYSVzk+CSsU IJhavU4bcnahgOM44Tm6c53D5oxcl14KB94bc/K6ItPFF3nBQ2Y52kfyb 9CUhfcHebYOu76J6a3p9xaaYUwGKWVhYvgS+vujkxyegyFURZQYAtFSsQ BNkVpiN5cglPYtHSP2mH6c+9J+b796OXoVQwUr1WD6pnbE7YE8KOI+r4J 4WDyR13/PyOXsfK/xdUFvZo7RD01Y; |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <201012151312.59779.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Organization: | Fujitsu Technology Solutions |
| References: | <201012151312.59779.Christoph.Egger@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101030 Iceowl/1.0b1 Icedove/3.0.10 |
On 12/15/10 13:12, Christoph Egger wrote: Hi! Attached patch open codes basename() with strrchr(). Fixes build on platforms like NetBSD where POSIX basename is available. Signed-off-by: Christoph Egger<Christoph.Egger@xxxxxxx>
> diff -r dcb46110d460 -r e8ce7e3e4b8c tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -5455,7 +5455,7 @@ int main_cpupoolcreate(int argc, char **
> if (!xlu_cfg_get_string (config, "name", &buf))
> name = strdup(buf);
> else
> - name = basename(filename);
> + name = strrchr(filename, '/') + 1;
> if (!libxl_name_to_cpupoolid(&ctx, name, &poolid)) {
> fprintf(stderr, "Pool name \"%s\" already exists\n", name);
> return -ERROR_FAIL;
This is not correct.
strrchr returns NULL here if filename contains no '/'. This leads to name
being 1.
Juergen
--
Juergen Gross Principal Developer Operating Systems
TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH 0 of 3] Fix up locking in log-dirty code, Tim Deegan |
|---|---|
| Next by Date: | [Xen-devel] Security Implications of letting customers use their own kernel, Jonathan Tripathy |
| Previous by Thread: | [Xen-devel] [PATCH][TOOLS] libxl: open code basename(), Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH][TOOLS] libxl: open code basename(), Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
