WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pvops: fix "xm save -c" issue

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pvops: fix "xm save -c" issue
From: Kenji Wakamiya <wkenji@xxxxxxxxxxxxxx>
Date: Wed, 15 Dec 2010 13:18:06 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 14 Dec 2010 20:19:10 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101214145925.GA5769@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D070138.7090708@xxxxxxxxxxxxxx> <20101214145925.GA5769@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.24 (Windows/20100228)
Hi Konrad, thank you for your response,

Konrad Rzeszutek Wilk wrote:
On Tue, Dec 14, 2010 at 02:31:36PM +0900, Kenji Wakamiya wrote:
Hi,

I'm investigating the issue of "xm save -c" in case of PV guests.
Then, I tried to prevent calling dpm_resume_end() when suspend was
canceled. It seems to work fine about blk and net.
How about this?


Could you give more details of what the failure is?

"xm save -c" saves domain state to storage and leaves it running after
creating snapshot. When this command is executed for a pvops
guest (xen/stable-2.6.32.x), the guest will hang up after accessing to
devices.

When the guest is unapused, stop_machine() in manage.c returns as the
suspend is cancelled. In that case, I think dpm_resume_end() should
not be called after stop_machine().

I tested vbd and net, the guest did not hang.
But I'm not sure if this is a right way...

Thanks,

Thanks,

Signed-off-by: Kenji Wakamiya <wkenji@xxxxxxxxxxxxxx>
Signed-off-by: Kazuhiro Suzuki <kaz@xxxxxxxxxxxxxx>
--
Kenji Wakamiya


diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index 0b50906..3dcc270 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -148,11 +148,10 @@ out_resume:
        if (!cancelled) {
                xen_arch_resume();
                xs_resume();
+               dpm_resume_end(PMSG_RESUME);
        } else
                xs_suspend_cancel();
- dpm_resume_end(PMSG_RESUME);
-
        /* Make sure timer events get retriggered on all CPUs */
        clock_was_set();

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel