WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/5] libxl: strdup disk path before put it in qem

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/5] libxl: strdup disk path before put it in qemu args array.
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Fri, 10 Dec 2010 12:29:04 +0000 (GMT)
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 10 Dec 2010 04:30:37 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1291972192.13966.4703.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1291923777-8712-1-git-send-email-anthony.perard@xxxxxxxxxx> <1291923777-8712-3-git-send-email-anthony.perard@xxxxxxxxxx> <1291972192.13966.4703.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 1.10 (DEB 962 2008-03-14)
On Fri, 10 Dec 2010, Ian Campbell wrote:

> On Thu, 2010-12-09 at 19:42 +0000, anthony.perard@xxxxxxxxxx wrote:
> > From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> >
> > In libxl_build_device_model_args_new, the path to the disk image are
> > freeed before there was actually use to make the arguments list of Qemu.
> > The patch strdups it.
> > ---
> >  tools/libxl/libxl.c |   10 +++++-----
> >  1 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > index 0feb93f..0f6e632 100644
> > --- a/tools/libxl/libxl.c
> > +++ b/tools/libxl/libxl.c
> > @@ -1256,9 +1256,9 @@ static char ** 
> > libxl_build_device_model_args_new(libxl__gc *gc,
> >      if (!dm_args)
> >          return NULL;
> >
> > -    flexarray_set(dm_args, num++, "qemu-system-xen");
> > -    flexarray_set(dm_args, num++, "-xen-domid");
> > +    flexarray_set(dm_args, num++, "qemu-dm");
>
> This bit doesn't seem to correspond to the patch description, was the
> change deliberate or did it slip in by mistake?

This change was deliberate. As this hunk don't really change anything, I
just don't explain it in the commit message. But I should have said the
following in the description.

Also it changes argv[0] of the device model from "qemu-system-xen" to
"qemu-dm".

I will resend the patch.

> (my kingdom for flexarray_append(...))

It will be too easy with this functions :)

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>