Re: [Xen-devel] [PATCH] tools/xl: only use the special "--incoming" name on actual migration

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 19:33 +0000 on 23 Nov (1290540816), Ian Jackson wrote:
> Tim Deegan writes ("[Xen-devel] [PATCH] tools/xl: only use the special 
> "--incoming" name on actual migration"):
> > tools/xl: only use the special "--incoming" name on actual migration
> > and not on every susequent reboot.
> 
> Well spotted.  However, doesn't this:
> 
> > +                            d_config.c_info.name = strdup(common_domname);
> 
> leak the old value of c_info.name ? 

In the case where this happens, the old name has been passed by
reference up the stack to the calling function, but in this path (the
child of a fork) we never return to the caller.  So, er, maybe?

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel