Re: [Xen-devel] [PATCH 07/16] xenpaging: populate only paged-out pages

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[Xen-devel] [PATCH 07/16] xenpaging: populate only 
paged-out pages"):
> populdate a paged-out page only once to reduce pressure in the ringbuffer.
> Several cpus may still request a page at once. xenpaging can handle this.
>
> But: maybe this will miss pages in paging-out state?

I can't answer your second question, but surely this pattern:

> -        p2m_mem_paging_populate(p2m, ram_gfn);
> +        if ( p2m_is_paged(p2mt) )
> +            p2m_mem_paging_populate(p2m, ram_gfn);

would better be done inside p2m_mem_paging_populate ?  Unless there
are some calls to _populate which should skip the check ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel