[Xen-devel] Re: [GIT PULL] Small Xen bugfixes

[Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>]

On Fri, Oct 29, 2010 at 11:57 AM, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
>
>    * fix dom0 boot on systems whose E820 doesn't completely cover the
>      ISA address space.  This fixes a crash on a Dell R310.

Hmm. This clashes with my current tree.

And that conflict is trivial to fix up, but the thing is, I think the
patch that comes from your tree is worse than what is already there.

Why is that simple unconditional

    e820_add_region(ISA_START_ADDRESS, ISA_END_ADDRESS - ISA_START_ADDRESS,
           E820_RESERVED);

not just always the right thing? Why do you have a separate hack for
dom0 in xen_release_chunk() instead? That just looks bogus.

The normal logic we use on PC's is to just always reserve the low 64kB
of memory, and the whole ISA space. Why doesn't Xen just do the same?

                          Linus

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel