This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] X86: Prefer TSC-deadline timer in Xen

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] X86: Prefer TSC-deadline timer in Xen
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Fri, 29 Oct 2010 09:00:45 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "Brown, Len" <len.brown@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Thu, 28 Oct 2010 18:01:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1851df96-69aa-4fea-99f2-76871455b348@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20101028142232.GB11016@xxxxxxxxxxxxxxxxxxxxxxx> <C8EF4A4A.268D2%keir@xxxxxxx F26D193E20BBDC42A43B611D1BDEDE71218A9898A9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1851df96-69aa-4fea-99f2-76871455b348@default>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Act278ahu6q1enFDSza1qFQ7JBR8OgAE61mQ
Thread-topic: [Xen-devel] [PATCH] X86: Prefer TSC-deadline timer in Xen
Architecturally the TSC Deadline feature comes along with reliable TSC.

For hot-add physical CPU case, if original APIC timer & TSC calibration work 
well, then TSC Deadline should not have problem.


> -----Original Message-----
> From: Dan Magenheimer [mailto:dan.magenheimer@xxxxxxxxxx]
> Sent: Friday, October 29, 2010 6:29 AM
> To: Wei, Gang; Keir Fraser; Tim Deegan
> Cc: Brown, Len; xen-devel@xxxxxxxxxxxxxxxxxxx; Jan Beulich
> Subject: RE: [Xen-devel] [PATCH] X86: Prefer TSC-deadline timer in Xen
> The change to cstate_restore_tsc reminds me...
> TSC should never be written if it is being used to
> generate system time, and I think cstate_restore_tsc
> is only used on systems where another clocksource
> is used to generate system time.   (And it generates
> a rather poor approximation of TSC.)  Are there any
> machines where cstate_restore_tsc might get executed
> but TSC_Deadline is in use?  If so, might there be
> a race condition here?  Also, are there any
> issues with using TSC Deadline on a system with
> the potential for hot-add physical CPUs?
> I suspect cstate_restore_tsc doesn't get executed
> if TSC is reliable, and the TSC Deadline feature
> is probably only available on systems where TSC
> is reliable, but am not sure.
> Thanks,
> Dan

Xen-devel mailing list