WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support

from [Jan Beulich] [Permanent Link][Original]
To: "Haitao Shan" <maillists.shan@xxxxxxxxx>
Subject: Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Thu, 28 Oct 2010 08:15:23 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Weidong Han <weidong.han@xxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 28 Oct 2010 00:16:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTim5DO3HQ_QCv-MK4auz7GDY3Mx+8g7MQJgsiVPS@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTimWUuyHvZ06=2cRBhvw2fcfMzA5QAuJZJso7=gY@xxxxxxxxxxxxxx> <4CC81AD8020000780001F6BE@xxxxxxxxxxxxxxxxxx> <AANLkTim5DO3HQ_QCv-MK4auz7GDY3Mx+8g7MQJgsiVPS@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
>>> On 28.10.10 at 06:58, Haitao Shan <maillists.shan@xxxxxxxxx> wrote:
> This is the updated patch#2. Thanks.

Sorry, but this is worse than not checking at all: You didn't consider
the idle vCPU case here, and hence you may end up having more
features enabled in xcr0 for a guest than it should have.

Also I only now noticed that you're leaking the xsave_area allocation
in vcpu_initialize() if hvm_vcpu_initialise() fails.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [Xen-devel] RE: [RFC][PATCH][VTD][v3] consolidate VT-d quirks into a single file quirks.c, Jan Beulich
Next by Date:  Re: [Xen-devel] [Patch 4/4] Refining Xsave/Xrestore support, Jan Beulich
Previous by Thread:  Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support, Haitao Shan
Next by Thread:  Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support, Haitao Shan
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy