This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] caml-stubdom: fix "red zone" bug

To: Patrick Colp <pjcolp@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] caml-stubdom: fix "red zone" bug
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 27 Oct 2010 17:16:22 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 27 Oct 2010 09:17:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTik-ZoCnvJOKS=RTSj2Y3TrKpm226v-LXOs-CDWO@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <AANLkTik-ZoCnvJOKS=RTSj2Y3TrKpm226v-LXOs-CDWO@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Patrick Colp writes ("[Xen-devel] [PATCH] caml-stubdom: fix "red zone" bug"):
> According to the AMD64 ABI, the 128-byte area below %rsp is reserved
> for scratch space and should not be used by signal, interrupt, or
> exception handlers. However, Mini-OS does not adhere to this
> interface. 

How unpleasant.

> This patch fixes this issue by passing the -mno-red-zone flag to the
> ocaml configure script in the stubdom Makefile.

Perhaps it would be better to make Mini-OS adhere to the specified
interface ?  But I guess your patch is good in the meantime.


Xen-devel mailing list