This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 01 of 25] libxc: infrastructure for hypercall saf

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 01 of 25] libxc: infrastructure for hypercall safe data buffers
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Mon, 25 Oct 2010 17:04:27 +0100
Delivery-date: Mon, 25 Oct 2010 09:29:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <38e25ffde90ec62f659f.1287756943@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <38e25ffde90ec62f659f.1287756943@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
The following patch is needed before this one to fix build error in
xc_hcall_buf.c when building with stub domains.

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1288022053 -3600
# Node ID 53b519f53bc1471610ab1423e3c70288a6c867b5
# Parent  3b5c6d7181fecdf6c1043a35047632ddf9950343
minios: add parentheses to mlock/mulock arguments.

Fixes warning/build error with non-trivial arguments.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 3b5c6d7181fe -r 53b519f53bc1 extras/mini-os/include/posix/sys/mman.h
--- a/extras/mini-os/include/posix/sys/mman.h   Mon Oct 25 14:56:39 2010 +0100
+++ b/extras/mini-os/include/posix/sys/mman.h   Mon Oct 25 16:54:13 2010 +0100
@@ -16,7 +16,7 @@
 void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t 
offset) asm("mmap64");
 int munmap(void *start, size_t length);
-#define munlock(addr, len) ((void)addr, (void)len, 0)
-#define mlock(addr, len) ((void)addr, (void)len, 0)
+#define munlock(addr, len) ((void)(addr), (void)(len), 0)
+#define mlock(addr, len) ((void)(addr), (void)(len), 0)
 #endif /* _POSIX_SYS_MMAN_H */

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>