This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH]: libxl: fix dom0 minimum memory threshold check

To: Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH]: libxl: fix dom0 minimum memory threshold check
From: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Date: Fri, 22 Oct 2010 15:07:31 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 22 Oct 2010 07:08:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1010221503050.10348@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1287752246.12843.4400.camel@xxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1010221503050.10348@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2010-10-22 at 15:04 +0100, Stefano Stabellini wrote:
> On Fri, 22 Oct 2010, Gianni Tedesco wrote:
> > libxl_set_memory_target tries to set the memory target for a given
> > domain to new_target_memkb. The function includes a check to make sure
> > that dom0's memory is not reduced below a minimal threshold ie.
> > LIBXL_MIN_DOM0_MEM. However, this check is performed before the
> > new_target_memkb variable is properly initialised - when the value is
> > always zero. This means that the check always fails. Fix this by moving
> > the test to happen after the proper initialisation of new_target_memkb.
> > 
> > Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
> > 
> I wonder what caused this block misplacement, maybe patch or hg import?
> Anyway:

FWIW, I blame hg, I've seen it do similar things before!


Xen-devel mailing list