This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH v4 03/10] xen: remap MSIs into pirqs when running

To: stefano.stabellini@xxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH v4 03/10] xen: remap MSIs into pirqs when running as initial domain
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Tue, 19 Oct 2010 16:24:47 -0400
Cc: Yunhong Jiang <yunhong.jiang@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Qing He <qing.he@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Delivery-date: Tue, 19 Oct 2010 13:26:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101019201518.GA9727@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1010191207010.2423@kaball-desktop> <1287487038-6643-3-git-send-email-stefano.stabellini@xxxxxxxxxxxxx> <20101019201518.GA9727@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
> > +   rc = HYPERVISOR_physdev_op(PHYSDEVOP_map_pirq, &map_irq);
> > +   if (rc) {
> > +           printk(KERN_WARNING "xen map irq failed %d\n", rc);
> > +
> > +           dynamic_irq_cleanup(irq);
> Looking at include/linux/irq.h, I see this commment:
>  /*
> 330  * Dynamic irq helper functions. Obsolete. Use irq_alloc_desc* and
> 331  * irq_free_desc instead.
> 332  */
> So we should use irq_free_desc instead of dynamic_irq_cleanup.
> (fyi, I didn't realize this until I started pulling in the sparse_irq
> patchset).

I looked at the rest of the patches and they all look good to me. Fix
this above and you can stick

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

on all the patches.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>