This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH]: msi: Mask out multi-function flag from PCI_HEAD

To: "Gianni Tedesco" <gianni.tedesco@xxxxxxxxxx>, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH]: msi: Mask out multi-function flag from PCI_HEADER_TYPE in read_pci_mem_bar()
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 19 Oct 2010 08:21:53 +0100
Cc: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Bruce Edge <bruce.edge@xxxxxxxxx>
Delivery-date: Tue, 19 Oct 2010 00:22:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1287422767.12843.840.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1287422767.12843.840.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Noticed I should have replied to this one.

>>> On 18.10.10 at 19:26, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx> wrote:
> This leads to an erroneous WARN_ON and possibly other side effects. It
> seems to me that even multi-function devices ought to enjoy the
> privilege of MSI-X capabilities.
> Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxxxx>

> diff -r fc2242ac90e1 xen/arch/x86/msi.c
> --- a/xen/arch/x86/msi.c      Mon Oct 18 11:31:47 2010 +0100
> +++ b/xen/arch/x86/msi.c      Mon Oct 18 18:14:22 2010 +0100
> @@ -527,7 +527,7 @@ static u64 read_pci_mem_bar(u8 bus, u8 s
>      u8 limit;
>      u32 addr;
> -    switch ( pci_conf_read8(bus, slot, func, PCI_HEADER_TYPE) )
> +    switch ( pci_conf_read8(bus, slot, func, PCI_HEADER_TYPE) & 0x7f )
>      {
>          limit = 6;

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>