This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 00/18] xenpaging changes for 4.0

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 00/18] xenpaging changes for 4.0
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Mon, 18 Oct 2010 12:26:01 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 18 Oct 2010 04:27:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101015141202.309585877@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20101015141202.309585877@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
Hi Olaf,

Thanks for all your work on this!

These patches look pretty good to me, with a few caveats:
- Is it possible to avoid having quite so many paths return ENOENT?
  In particular, there seemed to be paths where _removing_ a p2m entry
  that's paged out caused an error.  Would it be possible to have some of
  those cases fixed up from the paging code instead?
- The usual way to get patches into the 4.0 tree is to submit them
  againts xen-unstable and then ask for specific patches to be
  backported; I see you're already going that way with most of these.
- I imagine the tools maintainers will encourage you to do your tools
  patches againsl xl/libxl as well. :)



At 15:12 +0100 on 15 Oct (1287155522), Olaf Hering wrote:
> Here are some changes for xenpaging in the 4.0 branch.
> Its just for review and comments.  All changes are also needed for
> xen-unstable, I will prepare a patch queue also for this branch.
> There are still issues with xenpaging.
> My testsetup is a SLES11 SP1 guest with runlevel 6 as default runlevel to
> trigger automatic reboot.  After a few iterations, there will be MMIO 
> emulation
> errors.  This happens with a startup delay of 15.0 seconds.
> Another issue:
> If the startup delay is 0.0, and over_allocated in hvmloader mem_alloc is
> forced to be active, the ASSERT in p2m_remove_page() triggers. This is because
> the passed mfn and the mfn returned by ->get_entry() do not match.  So far I
> have no idea where the appearently missing set_gpfn_from_mfn() should go to.
> Normally over_allocated is not set because the XENMEM_populate_physmap call
> does not fail.
> Olaf
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Xen-devel mailing list