WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH 03/18] xenpaging: fix fd leak in xenstore

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH 03/18] xenpaging: fix fd leak in xenstore
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Fri, 15 Oct 2010 16:12:05 +0200
Delivery-date: Fri, 15 Oct 2010 07:17:52 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1287151931; l=606; s=domk; d=aepfle.de; h=References:Subject:To:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=h8doir7zTxtvPlYU4OSAut+8FxY=; b=BJpz/APziAcbikT+Hu55XU2xk0Rj1DbEF8bNHa8k/T1xmJsZXJIQB/NfIDpBG+QNy9o M3l28krEtRSa8P4ZoJhF0//HK2SCKD9sGyx9MWv+mdqPz1ISWR16pe0loxGEssWfMv3fp pk3nmdpSVm6UA0igVuKrCT44md4rA4bWiaU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20101015141202.309585877@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: quilt/0.48-4.4
Missing from commit 'libxl: Backported stuff from unstable'
Without this change, xs_daemon_open/xs_daemon_close will leak filedescriptors.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

---
 tools/xenstore/xs.c |    2 ++
 1 file changed, 2 insertions(+)

--- xen-4.0.1-testing.orig/tools/xenstore/xs.c
+++ xen-4.0.1-testing/tools/xenstore/xs.c
@@ -285,6 +285,8 @@ void xs_daemon_close(struct xs_handle *h
        mutex_unlock(&h->request_mutex);
        mutex_unlock(&h->reply_mutex);
        mutex_unlock(&h->watch_mutex);
+
+       close_fds_free(h);
 }
 
 static bool read_all(int fd, void *data, unsigned int len)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel