This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] How to handle missing create.dtd in tools/python/xen/xm/xena

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] How to handle missing create.dtd in tools/python/xen/xm/xenapi_create.py?
From: Stephan Peijnik <spe@xxxxxxxxx>
Date: Fri, 15 Oct 2010 10:56:10 +0200
Delivery-date: Fri, 15 Oct 2010 01:57:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Whilst writing my patch to replace the PyXML based XML validation code
in xenapi_create.py I noticed that the old code did not handle a missing
create.dtd file at all.

My patch (see [0]) now issues a warning when create.dtd is missing, but
I would like to know how we want to handle that case? 
Is issuing a Python warning enough or should we bail out with an error?
create.dtd should usually not be missing in xen installations, but the
Debian xen 4 package [1], in version 4.0.1-1, for example does not
include the create.dtd file and thus the validation will not be carried

Any other ideas on handling this? Is this a packaging bug or can
create.dtd be omitted in xen installations?



[0] http://xenbits.xensource.com/xen-unstable.hg?rev/b8cc53d22545
[1] http://packages.qa.debian.org/x/xen.html

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>