This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] xl: correct migration_domname_r

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xl: correct migration_domname_r
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Tue, 12 Oct 2010 16:48:36 +0100
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
Delivery-date: Tue, 12 Oct 2010 09:08:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1286898427 -3600
# Node ID 811dfe7ea7a79e5cb236c8c1fb81d47de22787d0
# Parent  7c7141f655fd2c561dac5589a93f21aacc2562f1
xl: correct migration_domname_r

22154:ed8019e672c6 causes migration_domname_r to be initialised as
d_config.c_info.name + "--incoming" immediately after setting
d_config.c_info.name. The intention appears to have been to set it to
common_domname + "--incoming" so do so.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 7c7141f655fd -r 811dfe7ea7a7 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Tue Oct 12 16:37:17 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c  Tue Oct 12 16:47:07 2010 +0100
@@ -1562,7 +1562,7 @@ static int create_domain(struct domain_c
             d_config.c_info.name = 0; /* steals allocation from config */
             if (asprintf(&d_config.c_info.name,
-                         "%s--incoming", d_config.c_info.name) < 0) {
+                         "%s--incoming", common_domname) < 0) {
                 fprintf(stderr, "Failed to allocate memory in asprintf\n");

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>