WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] libxl: copy & paste bug

On Tue, 2010-10-05 at 11:47 +0100, Christoph Egger wrote:
> On Tuesday 05 October 2010 12:08:18 Ian Campbell wrote:
> > On Tue, 2010-10-05 at 11:05 +0100, Christoph Egger wrote:
> > > Hi!
> > >
> > > In tools/libxl/libxl_bootloader.c, at the end of the
> > > function libxl_run_bootloader() are the following lines:
> > >
> > > if (fifo_fd > -1)
> > >     close(fifo_fd);
> > > if (bootloader_fd > -1)
> > >     close(bootloader_fd);
> > > if (xenconsoled_fd > -1)
> > >     close(xenconsoled_fd);
> > > if (xenconsoled_slave > -1)
> > >     close(xenconsoled_fd);
> > >
> > > The last line is wrong. It should be:
> > >
> > >     close(xenconsoled_slave);
> >
> > Indeed. Please can you post a patch.
> 
> Attached.

Thanks.

> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>