This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] Problem: Pattern with vertical colored lines on the dom

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] Problem: Pattern with vertical colored lines on the dom0 screen
From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Date: Mon, 4 Oct 2010 11:15:14 -0700
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "Han, Weidong" <weidong.han@xxxxxxxxx>, Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>, Konrad, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jean Guyader <jean.guyader@xxxxxxxxx>
Delivery-date: Mon, 04 Oct 2010 11:33:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CAA0DB1020000780001A6BC@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201009171520.11903.dietmar.hahn@xxxxxxxxxxxxxx> <201009241310.19462.dietmar.hahn@xxxxxxxxxxxxxx> <AANLkTin5bZdZch9y1kqUxoJHW8K4LMU5PUcuTpQLmZ0h@xxxxxxxxxxxxxx> <201009271406.26670.dietmar.hahn@xxxxxxxxxxxxxx> <20100927164706.GC4741@xxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D5301605D89C0@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4CA9AB33020000780001A522@xxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D530160643BAC@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4CAA0DB1020000780001A6BC@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Actj2DA6Pu8igamRS+S5UtelCj/CZQAFz1HQ
Thread-topic: [Xen-devel] Problem: Pattern with vertical colored lines on the dom0 screen
> Yes, and vendor/class check would seem reasonable here.

How do you differentiate Intel IGD and discrete graphics with this method?

> Perhaps I didn't say clearly enough what I mean: I'd want the first
> if()'s constituents changed (i.e. to
>    if ( is_igd_drhd(drhd) && !is_igd_vt_enabled() )
>) so that the easy test gets executed first, and the PCI config
>space access is avoided as much as possible. This would be less
>of an issue if you knew that the device you're trying to read
>from is actually an IGD.

Sounds reasonable thing to do as a general rule.  By the way the code here is 
only used during boot time. I will change it as part of the vt-d quirk 
consolidation and cleanup.


Xen-devel mailing list