[Xen-devel] Re: [PATCH 12/12] xen/mtrr: Add mtrr_if support for Xen mtrr

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

 On 09/28/2010 05:39 AM, Ingo Molnar wrote:
> * stefano.stabellini@xxxxxxxxxxxxx <stefano.stabellini@xxxxxxxxxxxxx> wrote:
>
>> From: Stephen Tweedie <sct@xxxxxxxxxx>
>>
>> Add a Xen mtrr type, and reorganise mtrr initialisation slightly to
>> allow the mtrr driver to set up num_var_ranges (Xen needs to do this by
>> querying the hypervisor itself.)
>>
>> [ Impact: add basic MTRR support ]
>>
>> Signed-off-by: Stephen Tweedie <sct@xxxxxxxxxx>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>> ---
>>  arch/x86/kernel/cpu/mtrr/Makefile |    2 +-
>>  arch/x86/kernel/cpu/mtrr/main.c   |    3 +
>>  arch/x86/kernel/cpu/mtrr/mtrr.h   |    7 ++
>>  arch/x86/kernel/cpu/mtrr/xen.c    |  110 
>> +++++++++++++++++++++++++++++++++++++
>>  4 files changed, 121 insertions(+), 1 deletions(-)
>>  create mode 100644 arch/x86/kernel/cpu/mtrr/xen.c
> Still NAK, for the very same reasons as we NAK-ed it the previous time: 
> /proc/mtrr is a problematic and complicated legacy interface that should 
> die.

Is your objection because we're adding a Xen mtrr implementation at all,
or because we're (slightly) extending the mtrr interface to do it?

Thanks,
    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel