WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] odd gfn number checking in p2m.c

To: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] odd gfn number checking in p2m.c
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sun, 19 Sep 2010 17:41:56 +0100
Cc:
Delivery-date: Sun, 19 Sep 2010 09:42:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100919154903.GA32635@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActYEkeXOlE7NirPTTemg1evwrr46AAB0qUv
Thread-topic: [Xen-devel] odd gfn number checking in p2m.c
User-agent: Microsoft-Entourage/12.26.0.100708
I think the 0x55555 checks are a bit of a hack. It just happens to be the
value we initialise the m2p table to at boot time. Afaik we don't initialise
free mfns back to 0x555...55 in the m2p, so over time that value will become
less frequent in the m2p.

 -- Keir

On 19/09/2010 16:49, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

> 
> Hello,
> 
> how can a gfn become 0x555555 as checked in
> p2m.c:guest_physmap_add_entry() and p2m_alloc_table()?
> Looking further in p2m.c, audit_p2m() checks only for a 32bit value.
> 
> So where is that magic number set, and why is it not a define to
> simplify grepping for users of that value?
> 
> Olaf
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>