Re: [Xen-devel] [Patch][resend] implementation of cpupool suppor

To:	Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [Patch][resend] implementation of cpupool support in xl
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Wed, 15 Sep 2010 11:23:43 +0200
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Wed, 15 Sep 2010 02:24:20 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1284542639; x=1316078639; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4C90909F.7070700@xxxxxxxxxxxxxx>\|Date:=20 Wed,=2015=20Sep=202010=2011:23:43=20+0200\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20Ian=20Campbell=20<Ian.Campbell@xxxxxxxxxxxxx >\|CC:=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@list s.xensource.com>\|Subject:=20Re:=20[Xen-devel]=20[Patch][r esend]=20implementation=20of=20cpupool=20support=0D=0A=20 in=20xl\|References:=20<4C907510.3070904@xxxxxxxxxxxxxx> =09<1284539351.14311.18361.camel@xxxxxxxxxxxxxxxxxxxxxx> =09<4C9087B7.4090205@xxxxxxxxxxxxxx>=20<1284542187.14311. 18454.camel@xxxxxxxxxxxxxxxxxxxxxx>\|In-Reply-To:=20<12845 42187.14311.18454.camel@xxxxxxxxxxxxxxxxxxxxxx> \|Content-Transfer-Encoding:=207bit; bh=8utZyH9wWJGAXqwi7jRADXpRv03ejc4xELPAnpaoQBQ=; b=f7H4J8Wp3Gws9vRp6/0rhqEhV4BE/IuCT+rtIeR4kHIaOZCII9FzDsi2 yhatY5N1DjYoVC5Lsb0TL735dYYIbYADDh1sFBsbHQvsiyZAnjSoOiSuN cndhgyhpqZR8aP6a+XjjI+KXWF9C1L09Wi8tJxesOLu/8bi+wk0cxTQVx Tp+/htTXofcoq/Tj7cKNE90gssJ2MFdRm8sfBNTlkL84fzU2SIiWa+KOH 77o+HXLJvKcUrZjGDF4MqDbaLT4eO;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=jHi+C0xH/VotRgIrbEDxDxkDXQQ/1MrIolQ0abUN99Ck9Q8mXF55F3Jf ZpeXOueZizhFJThCMsZ2wTa2aqEFh8LvGhh7vMC1khESjaFREM8KIo95L TVn2jQ9d6BhvoJ9GqEmVTI+XwpfyWHYB/T8ab+qAagzPNccvgjYiF09yq UC4CrbCY2JH46EDQs92yC/f1wroaYm1wHXw03jATCWhyo1fnKA5Jnht16 e35E3UnG/ZDOZyjj32OUc/qHCasHn;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1284542187.14311.18454.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<4C907510.3070904@xxxxxxxxxxxxxx> <1284539351.14311.18361.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C9087B7.4090205@xxxxxxxxxxxxxx> <1284542187.14311.18454.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Iceowl/1.0b1 Icedove/3.0.6

On 09/15/10 11:16, Ian Campbell wrote:

On Wed, 2010-09-15 at 09:45 +0100, Juergen Gross wrote:

On 09/15/10 10:29, Ian Campbell wrote:

On Wed, 2010-09-15 at 08:26 +0100, Juergen Gross wrote:

diff -r 3985fea87987 tools/libxl/libxl.idl
--- a/tools/libxl/libxl.idl     Fri Sep 10 19:06:33 2010 +0100
+++ b/tools/libxl/libxl.idl     Wed Sep 15 09:19:02 2010 +0200
@@ -43,7 +43,11 @@ SHUTDOWN_* constant."""),
       ], destructor_fn=None)

   libxl_poolinfo = Struct("poolinfo", [
-    ("poolid", uint32)
+    ("poolid",      uint32),
+    ("sched_id",    uint32),
+    ("n_dom",       uint32),
+    ("cpumap_size", uint32),
+    ("cpumap",      libxl_cpumap)
       ], destructor_fn=None)

   libxl_vminfo = Struct("vminfo", [


Does the addition of the cpumap field here mean that we now need to
generate a destructor function (by removing destructor_fn=None) and call
it e.g. from main_pool*?


I took care of this by allocating the space for the cpumap(s) together with
the poolinfo structure(s).
If you don't like this, a destructor would be the correct solution, I think.


Personally I would prefer using the destructor style for consistency
with other libxl types.


Okay, I'll change it accordingly.

I'll update the patch. It would be nice to know whether you are planning to
change libxl_cpumap to include the size or not.


I wasn't immediately planning on it but I can if you don't want to do it
as part of this patchset.


I think it shouldn't be included in this patch. :-)
And I'm not sure I'll get the generating of the bindings correctly.
So yes, please do it!


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [Patch][resend] implementation of cpupool support in xl