WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH V4] libxl: make libxl communicate with xenstored

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH V4] libxl: make libxl communicate with xenstored by socket or xenbus driver
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Wed, 15 Sep 2010 09:41:49 +0100
Cc: "Jun Zhu \(Intern\)" <Jun.Zhu@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 15 Sep 2010 01:42:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19599.41566.729352.138960@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <433DDF91DFB08148BAD3FDB6FDDA314C9F35F3BB6A@xxxxxxxxxxxxxxxxxxxxxxxxx> <19599.41566.729352.138960@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2010-09-14 at 17:27 +0100, Ian Jackson wrote:
> Jun Zhu (Intern) writes ("RE: [Xen-devel] [PATCH V4] libxl: make libxl 
> communicate with xenstored by socket or xenbus driver"):
> > Since libxl__xs_open does not ctx which LIBXL__LOG needs, so I choose to 
> > output log with the raw fprintf. 
> 
> Then the right answer is to make it take a ctx parameter, surely ?

gc->owner contains the surrounding context, doesn't it?

Actually you probably want to use libxl__gc_owner().

> And ensure that during initialisation, the logging is initialised
> before the xenstore connection.)

This seems to be the case in libxl_ctx_init().

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel