WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 05/16] vmx: nest: virtual vmcs layout

To: Qing He <qing.he@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 05/16] vmx: nest: virtual vmcs layout
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Mon, 13 Sep 2010 11:29:14 +0100
Cc: Eddie, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Dong <eddie.dong@xxxxxxxxx>
Delivery-date: Mon, 13 Sep 2010 03:30:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1283959344-3837-6-git-send-email-qing.he@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1283959344-3837-1-git-send-email-qing.he@xxxxxxxxx> <1283959344-3837-6-git-send-email-qing.he@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
At 16:22 +0100 on 08 Sep (1283962933), Qing He wrote:
> + * Since physical VMCS layout is unknown, a custom layout is used
> + * for virtual VMCS seen by guest. It occupies a 4k page, and the
> + * field is offset by an 9-bit offset into u64[], The offset is as
> + * follow, which means every <width, type> pair has a max of 32
> + * fields available.

A question - is this layout likely to have to change often in future?
(I guess the answer's no but you'll know best.)  We'll have to carry
compatibility code indefinitely so that VMs can be migrated to newer
Xens without breaking.

> + *             9       7      5               0
> + *             --------------------------------
> + *     offset: | width | type |     index     |
> + *             --------------------------------
> + *
> + * Also, since the lower range <width=0, type={0,1}> has only one
> + * field: VPID, it is moved to a higher offset (63), and leaves the
> + * lower range to non-indexed field like VMCS revision.
> + *
> + */
> +
> +#define VVMCS_REVISION 0x40000001u
> +
> +struct vvmcs_header {
> +    u32 revision;
> +    u32 abort;
> +};

This structure isn't used anywhere in the rest of the patch series.
Oversight?

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>