|
xen-devel
RE: [Xen-devel] [PATCH 06/16] vmx: nest: handling VMX instruction exits
|
To: |
"He, Qing" <qing.he@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|
Subject: |
RE: [Xen-devel] [PATCH 06/16] vmx: nest: handling VMX instruction exits |
|
From: |
"Dong, Eddie" <eddie.dong@xxxxxxxxx> |
|
Date: |
Fri, 10 Sep 2010 15:05:01 +0800 |
|
Accept-language: |
en-US |
|
Acceptlanguage: |
en-US |
|
Cc: |
"Dong, Eddie" <eddie.dong@xxxxxxxxx>, "He, Qing" <qing.he@xxxxxxxxx> |
|
Delivery-date: |
Fri, 10 Sep 2010 00:10:51 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1283959344-3837-7-git-send-email-qing.he@xxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1283959344-3837-1-git-send-email-qing.he@xxxxxxxxx> <1283959344-3837-7-git-send-email-qing.he@xxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
ActPbQzkAbJR3bkSSdqE8DrDLF+z8QBSUMSg |
|
Thread-topic: |
[Xen-devel] [PATCH 06/16] vmx: nest: handling VMX instruction exits |
Qing He wrote:
> add a VMX instruction decoder and handle simple VMX instructions
> except vmlaunch/vmresume and invept
>
> Signed-off-by: Qing He <qing.he@xxxxxxxxx>
> Signed-off-by: Eddie Dong <eddie.dong@xxxxxxxxx>
>
> ---
>
> +static int __clear_current_vvmcs(struct vmx_nest_struct *nest)
> +{
> + int rc;
> +
> + if ( nest->svmcs )
> + __vmpclear(virt_to_maddr(nest->svmcs));
> +
> +#if !CONFIG_VVMCS_MAPPING
> + rc = hvm_copy_to_guest_phys(nest->gvmcs_pa, nest->vvmcs,
Qing:
Why this may be failure? The only reason may be nest->gvmcs_pa, but I
guess we already verified the address.
Thx, Eddie
> PAGE_SIZE); + if ( rc != HVMCOPY_okay )
> + return X86EMUL_EXCEPTION;
> +#endif
> +
> + nest->vmcs_valid = 0;
> +
> + return X86EMUL_OKAY;
> +}
> +
> +/*
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home