WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxc: restore: reset I/O fd to flags to back to

To: Ian Campbell <ian.campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxc: restore: reset I/O fd to flags to back to state caller passed us
From: Brendan Cully <brendan@xxxxxxxxx>
Date: Fri, 3 Sep 2010 12:59:33 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 03 Sep 2010 13:03:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f23b8e767b18bbeb867e.1283530032@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Ian Campbell <ian.campbell@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <f23b8e767b18bbeb867e.1283530032@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2010-08-04)
On Friday, 03 September 2010 at 17:07, Ian Campbell wrote:
> # HG changeset patch
> # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> # Date 1283530025 -3600
> # Node ID f23b8e767b18bbeb867ec18e3db9bf8639da40b0
> # Parent  35cc5da0dd970c885fafaaf05bb3c1594dc68020
> libxc: restore: reset I/O fd to flags to back to state caller passed us
> 
> In particular this causes us to turn O_NONBLOCK back off if we set it.
> 
> The caller may continue to use the fd for it's own protocol needs and
> may not be prepared to have it become non-blocking.
> 
> This probably only effects Remus now after my previous patch to signal
> the last checkpoint, since a regular migration will no longer set the
> fd non-blocking.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

It doesn't appear to break Remus.

Acked-by: Brendan Cully <brendan@xxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel