WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] qemu-xen: fix cpu hotplug

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] qemu-xen: fix cpu hotplug
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Sat, 4 Sep 2010 02:52:24 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Li, Xin" <xin.li@xxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 03 Sep 2010 11:53:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19585.12309.876877.562073@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1009021416500.2714@kaball-desktop> <19583.57113.276530.834290@xxxxxxxxxxxxxxxxxxxxxxxx> <BC00F5384FCFC9499AF06F92E8B78A9E1837FFC067@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <19585.12309.876877.562073@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActLjWGOOTXMDh47SeuzYU0rgnTrkAAC1Dag
Thread-topic: [Xen-devel] [PATCH] qemu-xen: fix cpu hotplug
Ian,

I have discussed with Stefano about current xl/xend situation:
1). current issue seems casued by xl side;
2). we don't need apply Stefano's patch, at least now;

Stefano, you will check xl side, right?

Thanks,
Jinsong


Ian Jackson wrote:
> Liu, Jinsong writes ("RE: [Xen-devel] [PATCH] qemu-xen: fix cpu
> hotplug"): 
>> Stabellini, I read your attached patch, it's OK.
> 
> So we should apply Stefano's patch ?  I'm not sure I'm convinced.
> 
>> In fact, we firstly implemented xenstore watch by same scheme of
>> your patch, watching each cpu node status:
>> /local/domain/xx/cpu/yy/availability=offline (online)
>> 
>> However, we finally didn't use this scheme. We watch 'common' node
>> instead: /local/domain/xx/cpu in this way, only 1 watch point need.
>> Considering vcpu number may become more and more in the future (say,
>> more than 128), it's more simple and reasonable.  (Watches can be
>> set at points in the hierarchy and an individual watch will be
>> triggered when anything at or below that point in the hierachy
>> changes)
> 
> Here you seem to be saying that the scheme that you implemented (in
> xend, I take it) is not the same as the one in Stefano's patch.
> 
>> Yes, I think there must be some confusion.
>> Currently 'xm vcpu-set' command works fine with both PV and HVM vcpu
>> hotplug. 
> 
> Right, good.
> 
>> Stabellini/Jackson, would your please tell me what xl recently
>> happened for vcpu hotplug?
> 
> Well, we accepted patches to try to implement "xl vcpu-set" to make it
> work like "xm vcpu-set" but they are apparently wrong.
> 
>>  is there any different ideas xl and xend about xenstore syntax?
> 
> xl should use the same syntax in xenstore as xend currently does.  If
> xm (and therefore xend) and qemu currently work properly then changing
> qemu will break xend.  Instead, libxl should be changed to use the
> same scheme as xend.
> 
>> (Each time 'xm vcpu-set' executed, xend will write all xenstore cpu
>> node status)
> 
> Right.
> 
> Thanks,
> Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel