WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Re: [PATCH] re-enable HVM PCI passthrough functionality

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Subject: RE: [Xen-devel] Re: [PATCH] re-enable HVM PCI passthrough functionality
From: "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>
Date: Thu, 2 Sep 2010 10:26:32 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 01 Sep 2010 19:30:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100901085632.GB1432@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <987664A83D2D224EAE907B061CE93D53015D9B1A3E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D53015D9B1AE3@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20100831091727.GA23648@xxxxxxxxxxxxxxxxxxxxxxx> <201008311135.29268.Christoph.Egger@xxxxxxx> <987664A83D2D224EAE907B061CE93D53015D9B1D00@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20100901085632.GB1432@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActJs7u6Kafm1oA1QEK9q9UQqAhXWQAkmlOw
Thread-topic: [Xen-devel] Re: [PATCH] re-enable HVM PCI passthrough functionality
With allen's patch, both vt-d and sr-iov can work now. Thanks allen.

best regards
yang


> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Tim Deegan
> Sent: Wednesday, September 01, 2010 4:57 PM
> To: Kay, Allen M
> Cc: Christoph Egger; xen-devel@xxxxxxxxxxxxxxxxxxx; Keir Fraser
> Subject: [Xen-devel] Re: [PATCH] re-enable HVM PCI passthrough functionality
> 
> At 17:13 +0100 on 31 Aug (1283274786), Kay, Allen M wrote:
> > I have updated the patch to indicate valid_mfn() cannot be used here
> > as MMIO pages are always above max_mem.  Also added sanity checking
> > for type == p2m_mmio_direct before clearing page table entry.  This
> > should fix both VT-d and SR-IOV issues reported recently as there are
> > no SR-IOV specific code in Xen.  As far as Xen is concern, SR-IOV
> > virtual function is just another PCI device.
> 
> Applied; thanks for the fix.
> 
> Tim.
> 
> > Signed-off-by: Allen Kay allen.m.kay@xxxxxxxxx
> >
> > -----Original Message-----
> > From: Christoph Egger [mailto:Christoph.Egger@xxxxxxx]
> > Sent: Tuesday, August 31, 2010 2:35 AM
> > To: Tim Deegan
> > Cc: Kay, Allen M; xen-devel@xxxxxxxxxxxxxxxxxxx; Keir Fraser
> > Subject: Re: [PATCH] re-enable HVM PCI passthrough functionality
> >
> > On Tuesday 31 August 2010 11:17:27 Tim Deegan wrote:
> > > At 02:58 +0100 on 31 Aug (1283223494), Kay, Allen M wrote:
> > > > Attached patch reverts back to INVALID_MFN.  PCI passthrough
> > > > functionality works with this patch.
> > >
> > > Apologies for missing this - I did ask for this enormous patch to
> > > contain only what it said on the tin (and I did read it to check!) but
> > > this one got through.
> >
> > Also apologies from my side. I did what Tim requested for, but that
> > one slipped through.
> >
> > > > Signed-off-by: Allen Kay allen.m.kay@xxxxxxxxx
> > >
> > > This is fine, but please add a comment explaining the rather subtle use
> > > of INVALID_MFN here so the next tidy-minded person doesn't "fix" it
> > > again. :)
> > >
> > > In fact would it be better to check the returned type == p2m_mmio_direct
> > > instead?  That seems like it would fit better with the intention.   Or
> > > do other callers use this to clean non-mmio entries too?
> >
> > I'm interested in if this patch fixes the SR-IOV issue. We are still about
> > investigation...
> >
> > Christoph
> >
> >
> >
> > --
> > ---to satisfy European Law for business letters:
> > Advanced Micro Devices GmbH
> > Einsteinring 24, 85609 Dornach b. Muenchen
> > Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
> > Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
> > Registergericht Muenchen, HRB Nr. 43632
> >
> 
> 
> 
> --
> Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> Principal Software Engineer, XenServer Engineering
> Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel