This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix bootloader handling when empty string is bei

To: Michal Novotny <minovotn@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix bootloader handling when empty string is being output
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 31 Aug 2010 18:56:56 +0100
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 31 Aug 2010 10:58:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C7BADAA.9080209@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4C7BADAA.9080209@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Michal Novotny writes ("[Xen-devel] [PATCH] Fix bootloader handling when empty 
string is being output"):
> this is the patch to fix empty string as the output value
> of the bootloader string. If there is no output then
> xend is being hung indefinitely unless you press Ctrl + C keys
> to trigger SIGINT. This patch fixes the issue by implementing
> timeout to the select() function for reading from pipe and also
> checking for state of the process - i.e. whether the process is
> running or whether it's dead or zombie (because fork() call does
> leave zombies when the process is done but the parent process is
> still running).

This is a rather strange way to go about collecting the exit status
from a process.  What is pygrub's parent in this situation ?  Isn't it
xend ?  In which case xend has no need to grobbling around in /proc,
it can just call waitpid.


Xen-devel mailing list