This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxl: minor portability nits

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: minor portability nits
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 31 Aug 2010 17:57:26 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 31 Aug 2010 09:58:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201008261754.31958.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <201008261754.31958.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: minor portability nits"):
> Use #defines for network related default settinsg.
> Distinguish between default Linux and NetBSD network bridge interfaces.

I don't understand how and when NET_DEFAULT_ADDRESS ought to be set to
something different at compile-time.  If what you want is a global
setting, for the administrator to arrange to bind to a particular
address of the host (and you are happy with the security
implications), then I agree that we need a global config file for this
and various other reasons.  But not a #define.

> +#define NET_DEFAULT_ADDRESS       ""
> +#if defined(__linux__)
> +#define NET_DEFAULT_BRIDGE        "xenbr0"
> +#endif
> +#if defined(__NetBSD__)
> +#define NET_DEFAULT_BRIDGE        "bridge0"
> +#endif

This should be in libxl_osdeps.h.
Furthermore, the xenbr0 version should be the default.  Ie.
 +#define NET_DEFAULT_BRIDGE        "xenbr0"
preceded by some suitable thing for netbsd.  Also please use #ifdef
not #if defined(...).


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>