This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] libxl: fix xenstore connection when run in d

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] libxl: fix xenstore connection when run in domU
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Tue, 31 Aug 2010 11:28:51 +0100
Cc: "Jun Zhu \(Intern\)" <Jun.Zhu@xxxxxxxxxx>, "dgdegra@xxxxxxxxxxxxx" <dgdegra@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 31 Aug 2010 03:29:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1283246119.12544.9287.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <433DDF91DFB08148BAD3FDB6FDDA314C9F35F3BB4F@xxxxxxxxxxxxxxxxxxxxxxxxx> <1283246119.12544.9287.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
At 10:15 +0100 on 31 Aug (1283249719), Ian Campbell wrote:
> On Tue, 2010-08-31 at 10:05 +0100, Jun Zhu (Intern) wrote:
> > Hi
> > 
> > There are other places that use the xs_daemon_open in libxl. Is it 
> > necessory to change them as follows?
> >      ctx->xsh = xs_daemon_open();
> > +    if (!ctx->xsh)
> > +        ctx->xsh = xs_domain_open();
> >      if (!ctx->xsh) {
> >          XL_LOG_ERRNOVAL(ctx, XL_LOG_ERROR, errno, 
> >                          "cannot connect to xenstore");
> I think we'd be better off introducing "libxl__xs_open" which does the
> right thing and make the users to all use it.
> Is there any harm in always preferring xs_domain_open, even if the
> xenstore daemon happens to be co-located in the same domain?

I don't think so; even the performance probably won't be that much
different.  It certainly used to work when we first put Xenstore in its
own domain and anything that's broken since then is a regression worth


Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Xen-devel mailing list