Re: [Xen-devel] [GIT PULL] Fix lost interrupt race in Xen event channels

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

 On 08/30/2010 01:03 AM, Jan Beulich wrote:
> This totals to it having been wrong to break up -mask() and ->ack() -
> when using the combined ->mask_ack() (like in XCP etc) it would have
> been pretty obvious that move_native_irq() cannot go between
> mask() and ack().

Probably, but I just viewed the mask_ack() as an optimisation that
didn't need to be addressed on the first pass.  I converted the basic
event channels to fasteoi and it seems to work OK.  I'll look at pirq today.

> For us, using fasteoi, move_native_irq() sits in ->eoi(), before
> un-masking. One could, as Jeremy suggests, call move_masked_irq()
> here, but I didn't want to duplicate the IRQ_DISABLED check done
> in move_native_irq(), mainly to not depend on following potential
> future changes (additions) to the set of conditions checked there.

Is there actually a problem with moving a IRQ_DISABLED interrupt?  If
so, shouldn't that IRQ_DISABLED check also be in move_masked_irq()?

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel