This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 3/7] vtpm Mini-Os domain: mini-os defines

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/7] vtpm Mini-Os domain: mini-os defines
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 30 Aug 2010 12:42:11 +0100
Cc: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 30 Aug 2010 04:42:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100825153929.GX5341@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C753378.9070200@xxxxxxxxxx> <20100825153929.GX5341@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 25 Aug 2010, Samuel Thibault wrote:
> The principle is probably useful indeed.
> Matthew Fioravante, le Wed 25 Aug 2010 11:15:04 -0400, a ??crit :
> > This patch adds some #defines to mini-os
> I tend to frown upon "negative" flags, as they're less readable. I know
> that using "positive" will require adding them to all other stubdom
> projects, but it's probably still better that way: we'll realize for
> instance that pv-grub doesn't actually need pcifront :)
I agree, also all those ifdef's make the code difficult to read.
Wouldn't it be possible to enable/disable the compilation of those files
altogether and provide stubs for the export functions instead?

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>