This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: xen_hvm_callback_vector

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: xen_hvm_callback_vector
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 30 Aug 2010 10:37:09 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 30 Aug 2010 02:37:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C798243.7000301@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C7842C3.2000300@xxxxxxxx> <1283019557.3469.47.camel@xxxxxxxxxxxxxxxxxxxxx> <4C798243.7000301@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Sat, 28 Aug 2010, Jeremy Fitzhardinge wrote:
>  On 08/28/2010 11:19 AM, Ian Campbell wrote:
> > xen_evtchn_do_upcall is used for the callback vector interrupt injection
> > (and regular PV obviously).
> >
> > xen_hvm_evtchn_do_upcall is used by the old-style PCI IRQ injection
> > route in platform-pci.c if the callback vector is not available.
> >
> > So entry_64.S should be using xen_evtchn_do_upcall.
> >
> > Also, I think smp_xen_hvm_callback_vector is simply a redundant
> > duplicate of xen_evtchn_do_upcall which could be removed.

That's true, in fact I removed it in my tree.
It should be removed in the upstream version too, I just forgot to
send an update to Jeremy for the stable tree.

In my tree in entry_64 I have

        xen_hvm_callback_vector xen_evtchn_do_upcall

where xen_evtchn_do_upcall is the same callback that PV guests use and
smp_xen_hvm_callback_vector has been removed from drivers/xen/events.c

> smp_xen_hvm_callback_vector is just missing, so I think it should be
> using BUILD_INTERRUPT3 with the third arg being xen_evtchn_do_upcall.

BUILD_INTERRUPT3 is an x86_32 only MACRO, that's why I am using
apicinterrupt instead.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>