WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: paged granttable entries

To: Patrick Colp <pjcolp@xxxxxxxxx>
Subject: [Xen-devel] Re: paged granttable entries
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Thu, 26 Aug 2010 16:50:24 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 26 Aug 2010 07:51:11 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1282834227; l=632; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=65/cQc3BgIOaFq+JVtdxUb0w1po=; b=Mr35DLAbaiMRSEz8UgkooIjUSf7DwOHZw3eCqrmHvGBtV7FTJccEZSTg3um/VNwKKfn r6BKsO4EXOwcS+f127wOH/bK1sZF58CgUsPeUK85kUx4p6aZO+TR5/EPt8Z3gCDM3Ja3h wrWaNtuYeNpSjIJjym43iJxt27u6+XKt2Mo=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100826121355.GA6254@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100826121355.GA6254@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
Patrick,

while looking for other usage of p2m_mem_paging_populate(), I found two
calls in __gnttab_copy(). They set the error gnttab_copy_t->status to
-ENOENT.
Should this better be something from the GNTST_* namespace? I did not
see a check for -ENOENT "on the other side".

At least the kernel drivers in SLES11 do only check for GNTST_okay and
GNTST_eagain and GNTST_bad_page.


And a quick search for op->status usage shows a mix of GNTST_* and
status != 0. While it may not make much difference, perhaps there should
be some translation between the granttable error namespace and other
namespaces.


Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>