WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] xl: obey uuid config option

To: "Gianni Tedesco (3P)" <gianni.tedesco@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] xl: obey uuid config option
From: Owen Smith <owen.smith@xxxxxxxxxx>
Date: Thu, 26 Aug 2010 09:44:11 +0100
Accept-language: en-US
Acceptlanguage: en-US
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 26 Aug 2010 01:44:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1282761718.3731.100.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1282761718.3731.100.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActEhcjOinLF0WuFSPeJqWnKrVu+YgAdNjaQ
Thread-topic: [Xen-devel] [PATCH] xl: obey uuid config option
What should the behaviour be if the uuid config option is a valid string but an 
invalid format?

-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Gianni Tedesco
Sent: 25 August 2010 19:42
To: Xen Devel
Cc: Ian Jackson; Stefano Stabellini
Subject: [Xen-devel] [PATCH] xl: obey uuid config option

Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>

diff -r fd38d1c9f5ac tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Wed Aug 25 19:39:05 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c  Wed Aug 25 19:44:33 2010 +0100
@@ -607,7 +607,11 @@ static void parse_config_data(const char
         c_info->name = strdup(buf);
     else
         c_info->name = "test";
-    libxl_uuid_generate(&c_info->uuid);
+
+    if (!xlu_cfg_get_string (config, "uuid", &buf))
+        libxl_uuid_from_string(&c_info->uuid, buf);
+    else
+        libxl_uuid_generate(&c_info->uuid);
 
     if (!xlu_cfg_get_long(config, "oos", &l))
         c_info->oos = l;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>