WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] libxc: remove CPUID core information manglin

To: "Huang2, Wei" <Wei.Huang2@xxxxxxx>, "Przywara, Andre" <Andre.Przywara@xxxxxxx>, Nitin Kamble <nitin.a.kamble@xxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] libxc: remove CPUID core information mangling
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 25 Aug 2010 17:00:22 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 25 Aug 2010 09:02:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EE335F95F28A664DB4A21289D2AA053B73E7FC81@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActETlIeKSQ6fVmrTR+qm3z+KJqzSgABKEv2AAV8zVAAAK/EAQAAOwhwAACDaMA=
Thread-topic: [Xen-devel] Re: [PATCH] libxc: remove CPUID core information mangling
User-agent: Microsoft-Entourage/12.26.0.100708
Ah yes, I agree.


On 25/08/2010 16:53, "Huang2, Wei" <Wei.Huang2@xxxxxxx> wrote:

> OK. BTW, the old way seems wrong. The correct implementation should be
> (((regs[2] & 0xf000u) >> 12) + 1) << 12.
> 
> -----Original Message-----
> From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
> Sent: Wednesday, August 25, 2010 10:39 AM
> To: Huang2, Wei; Przywara, Andre; Nitin Kamble
> Cc: xen-devel
> Subject: Re: [Xen-devel] Re: [PATCH] libxc: remove CPUID core information
> mangling
> 
> I meant it should remain the old way, since HVM virtual APIC IDs are
> vcpu_id*2.
> 
>  -- Keir
> 
> On 25/08/2010 16:28, "Huang2, Wei" <Wei.Huang2@xxxxxxx> wrote:
> 
>> Hi Keir,
>> 
>> Do you mean that we should leave 80000008:ECX[15:12] as zero or in old way
>> (i.e. (regs[2] & 0xf000u) + 1))? These bits can't be zero, unless we want to
>> use legacy method in multi-core calculation.
>> 
>> -Wei
>> 
>> ========
>> I think you shouldn't change handling of 80000008:ECX[15:12] since that does
>> explicitly refer to APIC ID arrangement. The rest of your changes could be
>> correct as far as I can tell from the reference manuals.
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>> 
>> 
> 
> 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel