This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] Fix hvm vcpu hotplug bug

To: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Fix hvm vcpu hotplug bug
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 24 Aug 2010 15:19:23 +0100
Cc: Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Li, Xin" <xin.li@xxxxxxxxx>
Delivery-date: Tue, 24 Aug 2010 07:20:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BC00F5384FCFC9499AF06F92E8B78A9E18373CEDBE@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BC00F5384FCFC9499AF06F92E8B78A9E0B0007FD20@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <19554.43920.11785.97567@xxxxxxxxxxxxxxxxxxxxxxxx> <BC00F5384FCFC9499AF06F92E8B78A9E164C8CB703@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <19563.58860.249044.209893@xxxxxxxxxxxxxxxxxxxxxxxx> <BC00F5384FCFC9499AF06F92E8B78A9E165097298D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <19565.17092.616097.195948@xxxxxxxxxxxxxxxxxxxxxxxx> <BC00F5384FCFC9499AF06F92E8B78A9E16509730BB@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <19566.33227.5055.515834@xxxxxxxxxxxxxxxxxxxxxxxx> <BC00F5384FCFC9499AF06F92E8B78A9E18373CEDBE@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Liu, Jinsong writes ("RE: [Xen-devel] [PATCH] Fix hvm vcpu hotplug bug"):
> Ian Jackson wrote:
> > Liu, Jinsong writes ("RE: [Xen-devel] [PATCH] Fix hvm vcpu hotplug bug"): 
> >> [linux/drivers/acpi/acpica/ will:]
> >> 1). clear pge_en x by writing '0' to the bit;
> >> 2). asynchronic call control method;
> >> 3). clear gpe_sts x by writing '1' to the bit;
> >> 4). re-enable gpe_en x by writing '1' to the bit;
> > 
> > So the code in qemu should never clear gpe_sts itself.
> No, that's just what qemu should do, to simulate hardware behavior.

Obviously I still haven't understood.  If the guest kernel driver is
supposed to clear this bit as you seem to say above, then it should
not be cleared automatically by qemu-dm as part of the hotplug

Obviously the register ought to be emulated by qemu and the bit ought
to be cleared in qemu when the kernel driver writes an inactive value
to it.

None of this seems to be implemented in qemu right now AFAICT ?


Xen-devel mailing list