WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementatio

To: Juan Quintela <quintela@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 23 Aug 2010 14:15:09 +0100
Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 23 Aug 2010 06:16:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <m3zkwdpolk.fsf@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1008231019130.2545@kaball-desktop> <1282557052-14285-15-git-send-email-stefano.stabellini@xxxxxxxxxxxxx> <m3zkwdpolk.fsf@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Mon, 23 Aug 2010, Juan Quintela wrote:
> > +    register_savevm(NULL, "gpe", 0, 1, gpe_save, gpe_load, s);
> 
> Please port this to VMSTATE.
> 
> If possible (i.e. not problems with backwards compatibility), something like:
> 
> > +    for ( i = 0; i < ACPI_GPE0_BLK_LEN / 2; i++ ) {
> > +        qemu_get_8s(f, &s->gpe0_sts[i]);
> > +    }
> > +    for ( i = 0; i < ACPI_GPE0_BLK_LEN / 2; i++ ) {
> > +        qemu_get_8s(f, &s->gpe0_en[i]);
> > +    }
> 
> Would be easier to put in vmstate.
> 
 
Ok, will do.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel