Re: [Xen-devel] [PATCH] libxl: fix "xl console" for primary console

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 18 Aug 2010, Ian Campbell wrote:
> # HG changeset patch
> # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> # Date 1282145785 -3600
> # Node ID 02b341ca3612c0a76a11a9631e5e634922b8b483
> # Parent  bc64a2f2bdbf014dd122d970b3d4aac1d4444594
> libxl: fix "xl console" for primary console
> 
> libxl_console_constype is an enum and can therefore be unsigned so
> using -1 as a sentinel for unset in main_console fails to work as
> expected.
> 
> Arrange for all valid enum values to be > 0 and use 0 as the sentinal
> instead.
> 
> If the user does not request a specific type then always use the
> primary console since using "-n" but not "-t" is not meaningful as we
> do not know which type to request.
> 
> Also make libxl_console_exec reject invalid values of type.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel