This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH, v2] xl: make libxl_uuid2string internal to libxe

To: "Gianni Tedesco (3P)" <gianni.tedesco@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH, v2] xl: make libxl_uuid2string internal to libxenlight
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 16 Aug 2010 17:34:47 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 16 Aug 2010 09:35:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1281711766.18490.329.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1281711766.18490.329.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Fri, 13 Aug 2010, Gianni Tedesco (3P) wrote:
> libxenlight exports a function libxl_uuid2string which is used
> internally in several places but has one external caller in xl.
> This means that libxl internal callers leak since they were not
> expecting to have to free() the UUID since the per-api-call-gc-lifetime
> patch.
> Convert libxl_uuid2string to be an internal function which participates
> in the callers garbage collection. Eliminate string_of_uuid() macro in
> favour of "format" and "arguments" macros suitable for printf()-like
> functions which are made part of the libxl API and fix-up xl callers to
> use that to avoid code duplication and enhance readability.
> Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>

applied, thanks

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>