Re: [Xen-devel] [PATCH 0 of 3] libxl: leak in uuid to string conversions

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Fri, 2010-08-13 at 16:16 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH 0 of 3] libxl: leak in uuid to 
> string conversions"):
> > Fix a few memory leaks in the functions which convert uuids into
> > strings.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> (all three)
> 
> Ian.

I'm not sure I agree with this patch, especially 3 of 3. The callers are
inconsistent and also pointless. There's no need to allocate a uuid
string when all that's really needed is a few printf macros as in
"[PATCH,v2] xl: make libxl_uuid2string internal to libxenlight" - Also
UUID_FMT remains duplicated.

The first two patches are probably fine but then we should just nuke
libxl_uuid2string all together. Such a function makes sense for libxl
where it's going to be constructing xenstore paths so may need to keep
such things around but xl has no use for this as far as I can see.

Gianni


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel