This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH 1/2] Fix IOAPIC S3 with interrupt remapping enabled

To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH 1/2] Fix IOAPIC S3 with interrupt remapping enabled
From: "Han, Weidong" <weidong.han@xxxxxxxxx>
Date: Fri, 13 Aug 2010 16:59:09 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Fri, 13 Aug 2010 02:01:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acs6xcrsojqRwESwQw+QIpImRRpp2g==
Thread-topic: [Xen-devel] [PATCH 1/2] Fix IOAPIC S3 with interrupt remapping enabled
In ioapic_suspend, it reads and saves ioapic RTEs. But when interrupt remapping 
is enabled, io_apic_read will call io_apic_read_remap_rte to convert remapped 
format interrupt to compatible format, this results in 'dest' field may be 
changed in remap_entry_to_ioapic_rte. When in ioapic_resume, it will write the 
saved RTEs with incorrect 'dest' to interrupt remapping table.

Actually it needn't to convert RTEs regardless interrupt remapping is enabled 
or not. It just needs to save and restore RTE values directly. This patch just 
uses __io_apic_read and __io_apic_write, which won't call Interrupt remapping 
functions to convert, to save and restore RTEs in ioapic_suspend and 
ioapic_resume. Thus fix this issue.

Signed-off-by: Weidong Han <weidong.han@xxxxxxxxx>

Attachment: fix-ioapic-s3.patch
Description: fix-ioapic-s3.patch

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH 1/2] Fix IOAPIC S3 with interrupt remapping enabled, Han, Weidong <=