This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] msi: Avoid uninitialized msi descriptors

To: wei.wang2@xxxxxxx, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] msi: Avoid uninitialized msi descriptors
From: Dante Cinco <dantecinco@xxxxxxxxx>
Date: Wed, 11 Aug 2010 10:09:45 -0700
Delivery-date: Wed, 11 Aug 2010 10:10:50 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type:content-transfer-encoding; bh=qMkJwSLVIJ5+toB8AGbHXryEy/e2N6v6WJG9XFV6+88=; b=wCg79ex+nB+XCnxTvGelNUkWUOreor3C29UVZ7yAkcrLF3/GMIJEqsq/N3LwGCZElA gsuP0LYHut8h/q2IdALw1KWa8OKB9EiO1aQVwrWK6mEyyjzhFMiI4HU9VyViisnTTMRb pFlbyx8puoYgPvbtoRjC9AfejMK7JAhvcJ5bg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=gufiUXO2bgA0Q1QSWoqFs8qoAqKAhJklWZhr3inE7LlwLMsB52Sv+hC+wdj6C19d1+ KZo2sHaePh84D7YtKoz05H/NN7k5BlQKWbj5zPBzV3GOEpBBJsP4pmod/BnuXnDth+xk zJhtypIHcicF0+BeRkA+Qr5bRFJLKLuE3Q9YM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I'm glad that somebody who is familiar with MSI has resolved this
problem although I haven't applied and verified the proposed patch yet
on my system. I posted the Xen crash I experienced related to this
issue on xen-devel a couple of weeks ago (see link below) but wasn't
familiar enough with the MSI/MSI-X code to propose a solution other
than to back out changelist 21778.



-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Wei Wang2
Sent: Wednesday, August 11, 2010 6:43 AM
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] msi: Avoid uninitialized msi descriptors

When __pci_enable_msix() returns early, output parameter (struct msi_desc
**desc) will not be initialized.  On my machine, a Broadcom BCM5709
nic has both MSI and MSIX capability blocks and when guest tries to
enable msix interrupts but __pci_enable_msix() returns early for
encountering a msi block,  the whole system will crash for fatal page
fault immediately.


Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
AMD GmbH, Germany
Operating System Research Center

Legal Information:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34
85609 Dornach b. München

Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis München Registergericht
München, HRB Nr. 43632

Xen-devel mailing list