WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] use full-size cpumask for vcpu-pin

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] use full-size cpumask for vcpu-pin
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date: Wed, 11 Aug 2010 06:32:21 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 10 Aug 2010 21:33:18 -0700
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1281500731; x=1313036731; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4C6227D5.60408@xxxxxxxxxxxxxx>|Date:=20We d,=2011=20Aug=202010=2006:32:21=20+0200|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>|MIME-Version: =201.0|To:=20Ian=20Jackson=20<Ian.Jackson@xxxxxxxxxxxxx> |CC:=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@lists .xensource.com>|Subject:=20Re:=20[Xen-devel]=20[Patch]=20 use=20full-size=20cpumask=20for=20vcpu-pin|References:=20 <4C566844.2070408@xxxxxxxxxxxxxx>=20<19553.24054.564316.1 42633@xxxxxxxxxxxxxxxxxxxxxxxx>|In-Reply-To:=20<19553.240 54.564316.142633@xxxxxxxxxxxxxxxxxxxxxxxx> |Content-Transfer-Encoding:=207bit; bh=l8YzKE0r0JsE9JUalxnfQoMnamSacZcaFct67UNhm90=; b=cj11Njmvp7a+PAIV2u0oxsuiVbnd4iZY0K99ruSq9Fn1uAEL4SFTYujz JCb73RmmbcYUyX6jeqL0odHILuOth93zddHOZye0DSMCE0hokSp/XV23t nbwTlF3Jw1ykftgoRTXdlPGC98O0/T7MwFfrDdxKx/e84uUwEWXzvcJCq IAZNS4R6gc28DLkkklXdX/SCrvssyiELwxraTGSS7XQSSoVFckTU+aseG aOpRPEQ6iY1W9HowaZvtoC17C9OTi;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=fMWUsLcFk0Gq44WLCQkCzNLyd4eqxXCSSCPuORak2y5yDQvszgqcoW1s RIzEds/6myThhPboGcYpFcVhEuwdq66Ejk7pQNQR9WmTHMjA9g9nSTvEe GCO2tRGpmQn+SgklcFxCzON9B/ynUdr7DDDf6cIhpIkSt7X/INuwMGaZq h5/P/zAOrxgub4UzjDbbU2H5AutjoQfzc8MaKoLOsteGk8sgMWru+Ecrc n9+7A7n5RF0YrPx86Rd5k60fYVk1y;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19553.24054.564316.142633@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Technology Solutions
References: <4C566844.2070408@xxxxxxxxxxxxxx> <19553.24054.564316.142633@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100620 Iceowl/1.0b1 Icedove/3.0.5
On 08/10/10 16:11, Ian Jackson wrote:
Juergen Gross writes ("[Xen-devel] [Patch] use full-size cpumask for vcpu-pin"):
The reason is the allocation of the cpumap for pinning: the size is only for
the ACTUAL number of physical cpus in the system, not the possible number.
The solution is to allocate a cpumap for up to NR_CPUS.

Thanks for this patch.  However, this doesn't seem to be even slightly
backwards-compatible, because it changes the layout of the physinfo
sysctl response.

No, it doesn't change the layout. The new structure member just fills a hole
which was already there due to alignment of the next member.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel