This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xenoprof: Cleanup

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenoprof: Cleanup
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 10 Aug 2010 17:13:33 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 10 Aug 2010 09:14:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19553.30305.743166.641813@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acs4pIHgUDe+T58LRVO5aIBnqLmSqAAAni27
Thread-topic: [Xen-devel] [PATCH] xenoprof: Cleanup
User-agent: Microsoft-Entourage/
On 10/08/2010 16:55, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> KUWAMURA Shin'ya writes ("[Xen-devel] [PATCH] xenoprof: Cleanup"):
>> The declaration of ibs_caps also exists in xen/include/asm-x86/xenoprof.h.
> ...
>> -/* AMD IBS support */
>> -extern u32 ibs_caps;
> But, in xen/common/xenoprof.c, surely this should be a definition and
> not a declaration.  So more correct would be
>  -extern u32 ibs_caps;
>  +u32 ibs_caps;
> but that would conflict with the #define in
> xen/include/asm-ia64/xenoprof.h.  So I'm not sure this fix is complete.

It's defined in arch-specific arch/x86/oprofile/op_model_athlon.c. Exposed
to common/xenoprof.c in the arch-specific include/asm-x86/xenoprof.h (and
stubbed out in ia64's equivalent header).

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>